netdev - Re: [Linux-kernel-mentees] [PATCH net] tipc: Fix memory leak in tipc_group_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200912.182336.585362420502143240.davem@davemloft.net>
Date:   Sat, 12 Sep 2020 18:23:36 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     yepeilin.cs@...il.com
Cc:     jmaloy@...hat.com, ying.xue@...driver.com, kuba@...nel.org,
        hdanton@...a.com, gregkh@...uxfoundation.org,
        netdev@...r.kernel.org, tipc-discussion@...ts.sourceforge.net,
        linux-kernel-mentees@...ts.linuxfoundation.org,
        syzkaller-bugs@...glegroups.com, linux-kernel@...r.kernel.org
Subject: Re: [Linux-kernel-mentees] [PATCH net] tipc: Fix memory leak in
 tipc_group_create_member()

From: Peilin Ye <yepeilin.cs@...il.com>
Date: Sat, 12 Sep 2020 06:22:30 -0400

> @@ -291,10 +291,11 @@ static void tipc_group_add_to_tree(struct tipc_group *grp,
>  		else if (key > nkey)
>  			n = &(*n)->rb_right;
>  		else
> -			return;
> +			return -1;

Use a real error code like "-EEXIST", thank you.