lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 13 Sep 2020 10:10:35 +0200
From:   Willem de Bruijn <>
To:     Xie He <>
Cc:     Willem de Bruijn <>,
        "David S. Miller" <>,
        Jakub Kicinski <>,
        Network Development <>,
        linux-kernel <>,
        Eric Dumazet <>,
        Brian Norris <>,
        Cong Wang <>
Subject: Re: [PATCH net-next] net/packet: Fix a comment about hard_header_len
 and add a warning for it

On Sat, Sep 12, 2020 at 1:37 AM Xie He <> wrote:
> On Fri, Sep 11, 2020 at 7:32 AM Willem de Bruijn
> <> wrote:
> >
> > From a quick scan, a few device types that might trigger this
> >
> > net/atm/clip.c
> > drivers/net/wan/hdlc_fr.c
> > drivers/net/appletalk/ipddp.c
> > drivers/net/ppp/ppp_generic.c
> > drivers/net/net_failover.c
> I have recently fixed this problem in the "net" tree in hdlc_fr.c.
> Glad to see the number of drivers that have this problem is not very big.

I am concerned about adding a WARN_ON_ONCE that we already expect to
fire on some platforms.

Probably better to add the documentation without the warning.

I know I suggested the check before, sorry for the churn, but I hadn't
checked the existing state yet.

Powered by blists - more mailing lists