lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 13 Sep 2020 01:43:14 -0700 From: Xie He <xie.he.0141@...il.com> To: Willem de Bruijn <willemdebruijn.kernel@...il.com> Cc: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Network Development <netdev@...r.kernel.org>, linux-kernel <linux-kernel@...r.kernel.org>, Eric Dumazet <eric.dumazet@...il.com>, Brian Norris <briannorris@...omium.org>, Cong Wang <xiyou.wangcong@...il.com> Subject: Re: [PATCH net-next] net/packet: Fix a comment about hard_header_len and add a warning for it On Sun, Sep 13, 2020 at 1:11 AM Willem de Bruijn <willemdebruijn.kernel@...il.com> wrote: > > I am concerned about adding a WARN_ON_ONCE that we already expect to > fire on some platforms. > > Probably better to add the documentation without the warning. > > I know I suggested the check before, sorry for the churn, but I hadn't > checked the existing state yet. OK. No problem. It's always good to discuss and find out the best way before we do the changes. I'll drop the WARN_ON_ONCE part and resubmit the patch.
Powered by blists - more mailing lists