netdev - Re: [PATCH V1 net-next 2/8] net: ena: Add device distinct log prefix to files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200913.143022.1949357995189636518.davem@davemloft.net>
Date:   Sun, 13 Sep 2020 14:30:22 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     shayagr@...zon.com
Cc:     netdev@...r.kernel.org, dwmw@...zon.com, zorik@...zon.com,
        matua@...zon.com, saeedb@...zon.com, msw@...zon.com,
        aliguori@...zon.com, nafea@...zon.com, gtzalik@...zon.com,
        netanel@...zon.com, alisaidi@...zon.com, benh@...zon.com,
        akiyano@...zon.com, sameehj@...zon.com, ndagan@...zon.com,
        amitbern@...zon.com
Subject: Re: [PATCH V1 net-next 2/8] net: ena: Add device distinct log
 prefix to files

From: Shay Agroskin <shayagr@...zon.com>
Date: Sun, 13 Sep 2020 11:16:34 +0300

> ENA logs are adjusted to display the full ENA representation to
> distinct each ENA device in case of multiple interfaces.
> Using dev_err/warn/info function family for logging provides uniform
> printing with clear distinction of the driver and device.
> 
> This patch changes all printing in ena_com files to use dev_* logging
> messages. It also adds some log messages to make driver debugging
> easier.
> 
> Signed-off-by: Amit Bernstein <amitbern@...zon.com>
> Signed-off-by: Shay Agroskin <shayagr@...zon.com>

This device prefix is so much less useful than printing the actual
networking adapter that the ena_com operations are for.

So if you are going to do this, go all the way and pass the ena_adapter
or the netdev down into these ena_com routines so that you can use
the netdev_*() message helpers.

Thank you.