lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 14 Sep 2020 15:23:04 +0300
From:   Shay Agroskin <>
To:     David Miller <>
CC:     <>, <>, <>,
        <>, <>, <>,
        <>, <>, <>,
        <>, <>, <>,
        <>, <>, <>,
Subject: Re: [PATCH V1 net-next 2/8] net: ena: Add device distinct log prefix to files

David Miller <> writes:

> From: Shay Agroskin <>
> Date: Sun, 13 Sep 2020 11:16:34 +0300
>> ENA logs are adjusted to display the full ENA representation to
>> distinct each ENA device in case of multiple interfaces.
>> Using dev_err/warn/info function family for logging provides 
>> uniform
>> printing with clear distinction of the driver and device.
>> This patch changes all printing in ena_com files to use dev_* 
>> logging
>> messages. It also adds some log messages to make driver 
>> debugging
>> easier.
>> Signed-off-by: Amit Bernstein <>
>> Signed-off-by: Shay Agroskin <>
> This device prefix is so much less useful than printing the 
> actual
> networking adapter that the ena_com operations are for.
> So if you are going to do this, go all the way and pass the 
> ena_adapter
> or the netdev down into these ena_com routines so that you can 
> use
> the netdev_*() message helpers.
> Thank you.

Thanks you for reviewing it. Some of the ena_com functions are 
with dev* routines because the netdev struct isn't created when 
are executed.

We'll go over the other ena com routines (which are called when an
interface exists) and change them to netdev_* routines 
instead. I'll send a new version of the patchset once done.

Powered by blists - more mailing lists