netdev - Re: [PATCH net-next v2 06/13] mptcp: move ooo skbs into msk out of order queue.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.OSX.2.23.453.2009141106240.57764@ningale-mobl.amr.corp.intel.com>
Date:   Mon, 14 Sep 2020 11:06:50 -0700 (PDT)
From:   Mat Martineau <mathew.j.martineau@...ux.intel.com>
To:     Paolo Abeni <pabeni@...hat.com>
cc:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, mptcp@...ts.01.org
Subject: Re: [PATCH net-next v2 06/13] mptcp: move ooo skbs into msk out of
 order queue.

On Mon, 14 Sep 2020, Paolo Abeni wrote:

> Add an RB-tree to cope with OoO (at MPTCP level) data.
> __mptcp_move_skb() insert into the RB tree "future"
> data, eventually coalescing skb as allowed by the
> MPTCP DSN.
>
> To simplify sequence accounting, move the DSN inside
> the cb.
>
> After successfully enqueuing in sequence data, check
> if we can use any data from the RB tree.
>
> Additionally move the data_fin check after spooling
> data from the OoO tree, otherwise we could miss shutdown
> events.
>
> The RB tree code is copied as verbatim as possible
> from tcp_data_queue_ofo(), with a few simplifications
> due to the fact that MPTCP doesn't need to cope with
> sacks. All bugs here are added by me.
>
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>
> ---
> net/mptcp/protocol.c | 264 ++++++++++++++++++++++++++++++++++---------
> net/mptcp/protocol.h |   2 +
> net/mptcp/subflow.c  |   1 +
> 3 files changed, 211 insertions(+), 56 deletions(-)
>

Reviewed-by: Mat Martineau <mathew.j.martineau@...ux.intel.com>

--
Mat Martineau
Intel