netdev - Re: [PATCH net-next v2 07/13] mptcp: cleanup mptcp_subflow_discard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.OSX.2.23.453.2009141107280.57764@ningale-mobl.amr.corp.intel.com>
Date:   Mon, 14 Sep 2020 11:07:46 -0700 (PDT)
From:   Mat Martineau <mathew.j.martineau@...ux.intel.com>
To:     Paolo Abeni <pabeni@...hat.com>
cc:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, mptcp@...ts.01.org
Subject: Re: [PATCH net-next v2 07/13] mptcp: cleanup
 mptcp_subflow_discard_data()

On Mon, 14 Sep 2020, Paolo Abeni wrote:

> There is no need to use the tcp_read_sock(), we can
> simply drop the skb. Additionally try to look at the
> next buffer for in order data.
>
> This both simplifies the code and avoid unneeded indirect
> calls.
>
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>
> ---
> net/mptcp/protocol.h |  1 -
> net/mptcp/subflow.c  | 58 +++++++++++---------------------------------
> 2 files changed, 14 insertions(+), 45 deletions(-)
>

Reviewed-by: Mat Martineau <mathew.j.martineau@...ux.intel.com>

--
Mat Martineau
Intel