lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 14 Sep 2020 14:14:51 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     W_Armin@....de
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next v5 0/6] 8390: core cleanups

From: Armin Wolf <W_Armin@....de>
Date: Mon, 14 Sep 2020 23:01:22 +0200

> The purpose of this patchset is to do some
> cleanups in lib8390.c and 8390.c

A lot of these changes are borderline beneficial, at best.

You are adding include files to foo.c files that are already included
by lib8390.c already (which the foo.c file includes).  This is
redundant and makes the compiler work harder.  lib8390.c is
designed to work like this.

Your first patch mixes comment formatting with actual code
changes (adding new curly braces and such).

And so on and so forth...

I honestly don't like this patch series at all.

If you were about to add a big new feature to the 8390 code
and wanted to clean it up first before doing so, maybe I'd
be ok with these changes.  But as a pure cleanup, sorry I'm
not going to apply this stuff.

Powered by blists - more mailing lists