netdev - Re: [RESEND net-next v2 00/12]drivers: net: convert tasklets to use new tasklet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 14 Sep 2020 21:16:25 +0000
From:   Saeed Mahameed <saeedm@...dia.com>
To:     "davem@...emloft.net" <davem@...emloft.net>,
        "allen.lkml@...il.com" <allen.lkml@...il.com>
CC:     "m.grzeschik@...gutronix.de" <m.grzeschik@...gutronix.de>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "woojung.huh@...rochip.com" <woojung.huh@...rochip.com>,
        "petkan@...leusys.com" <petkan@...leusys.com>,
        "oliver@...kum.org" <oliver@...kum.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "UNGLinuxDriver@...rochip.com" <UNGLinuxDriver@...rochip.com>,
        "paulus@...ba.org" <paulus@...ba.org>,
        "linux-ppp@...r.kernel.org" <linux-ppp@...r.kernel.org>,
        "apais@...ux.microsoft.com" <apais@...ux.microsoft.com>
Subject: Re: [RESEND net-next v2 00/12]drivers: net: convert tasklets to use
 new tasklet_setup() API

On Mon, 2020-09-14 at 13:01 +0530, Allen Pais wrote:
> From: Allen Pais <apais@...ux.microsoft.com>
> 
> ommit 12cc923f1ccc ("tasklet: Introduce new initialization API")'
> introduced a new tasklet initialization API. This series converts
> all the net/* drivers to use the new tasklet_setup() API
> 
> This series is based on v5.9-rc5
> 
> Allen Pais (12):
>   net: mvpp2: Prepare to use the new tasklet API
>   net: arcnet: convert tasklets to use new tasklet_setup() API
>   net: caif: convert tasklets to use new tasklet_setup() API
>   net: ifb: convert tasklets to use new tasklet_setup() API
>   net: ppp: convert tasklets to use new tasklet_setup() API
>   net: cdc_ncm: convert tasklets to use new tasklet_setup() API
>   net: hso: convert tasklets to use new tasklet_setup() API
>   net: lan78xx: convert tasklets to use new tasklet_setup() API
>   net: pegasus: convert tasklets to use new tasklet_setup() API
>   net: r8152: convert tasklets to use new tasklet_setup() API
>   net: rtl8150: convert tasklets to use new tasklet_setup() API
>   net: usbnet: convert tasklets to use new tasklet_setup() API
> 
> 

You are only converting drivers which are passing the taskelt struct as
data ptr, most of other drivers are passing the container of the
tasklet as data, why not convert them as well, and let them use
container_of to find their data ? it is really straight forward and
will help convert most of net driver if not all.