lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Tue, 15 Sep 2020 08:28:17 +0200
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Wang Hai <wanghai38@...wei.com>, wg@...ndegger.com,
        davem@...emloft.net, kuba@...nel.org, gustavoars@...nel.org
Cc:     linux-can@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] can: peak_canfd: Remove unused macros

On 9/4/20 3:12 PM, Wang Hai wrote:
> CANFD_CLK_SEL_DIV_MASK and CANFD_OPTIONS_SET are
> never used after they were introduced. Remove them.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Wang Hai <wanghai38@...wei.com>
> ---
>  drivers/net/can/peak_canfd/peak_pciefd_main.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/net/can/peak_canfd/peak_pciefd_main.c b/drivers/net/can/peak_canfd/peak_pciefd_main.c
> index 9469d4421afe..5f0f39d2fa28 100644
> --- a/drivers/net/can/peak_canfd/peak_pciefd_main.c
> +++ b/drivers/net/can/peak_canfd/peak_pciefd_main.c
> @@ -83,7 +83,6 @@ MODULE_LICENSE("GPL v2");
>  #define CANFD_MISC_TS_RST		0x00000001	/* timestamp cnt rst */
>  
>  /* CAN-FD channel Clock SELector Source & DIVider */
> -#define CANFD_CLK_SEL_DIV_MASK		0x00000007

I would like to keep this for documentation purpose.

>  #define CANFD_CLK_SEL_DIV_60MHZ		0x00000000	/* SRC=240MHz only */
>  #define CANFD_CLK_SEL_DIV_40MHZ		0x00000001	/* SRC=240MHz only */
>  #define CANFD_CLK_SEL_DIV_30MHZ		0x00000002	/* SRC=240MHz only */
> @@ -116,8 +115,6 @@ MODULE_LICENSE("GPL v2");
>  #define CANFD_CTL_IRQ_CL_DEF	16	/* Rx msg max nb per IRQ in Rx DMA */
>  #define CANFD_CTL_IRQ_TL_DEF	10	/* Time before IRQ if < CL (x100 ┬Ás) */
>  
> -#define CANFD_OPTIONS_SET	(CANFD_OPTION_ERROR | CANFD_OPTION_BUSLOAD)
> -

Okay, let's remove this.

>  /* Tx anticipation window (link logical address should be aligned on 2K
>   * boundary)
>   */
> 

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |



Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)

Powered by blists - more mailing lists