lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Tue, 15 Sep 2020 08:31:03 +0200
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Wang Hai <wanghai38@...wei.com>, wg@...ndegger.com,
        davem@...emloft.net, kuba@...nel.org
Cc:     linux-can@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] can: kvaser_pciefd: Remove unused macro
 KVASER_PCIEFD_KCAN_CTRL_EFRAME

On 9/4/20 3:10 PM, Wang Hai wrote:
> KVASER_PCIEFD_KCAN_CTRL_EFRAME is never used after it was introduced.
> So better to remove it.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Wang Hai <wanghai38@...wei.com>
> ---
>  drivers/net/can/kvaser_pciefd.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/can/kvaser_pciefd.c b/drivers/net/can/kvaser_pciefd.c
> index 6f766918211a..c0b18ff107c7 100644
> --- a/drivers/net/can/kvaser_pciefd.c
> +++ b/drivers/net/can/kvaser_pciefd.c
> @@ -131,7 +131,6 @@ MODULE_DESCRIPTION("CAN driver for Kvaser CAN/PCIe devices");
>  
>  /* Kvaser KCAN definitions */
>  #define KVASER_PCIEFD_KCAN_CTRL_EFLUSH (4 << 29)
> -#define KVASER_PCIEFD_KCAN_CTRL_EFRAME (5 << 29)
>  
>  #define KVASER_PCIEFD_KCAN_CMD_SEQ_SHIFT 16
>  /* Request status packet */
> 

I'd like to keep this for documentation purpose, too.

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |



Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)

Powered by blists - more mailing lists