netdev - Re: [PATCH net] nfp: use correct define to return NONE fec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200917181059.GA13324@netronome.com>
Date:   Thu, 17 Sep 2020 20:11:00 +0200
From:   Simon Horman <simon.horman@...ronome.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        oss-drivers@...ronome.com
Subject: Re: [PATCH net] nfp: use correct define to return NONE fec

On Thu, Sep 17, 2020 at 10:52:57AM -0700, Jakub Kicinski wrote:
> struct ethtool_fecparam carries bitmasks not bit numbers.
> We want to return 1 (NONE), not 0.
> 
> Fixes: 0d0870938337 ("nfp: implement ethtool FEC mode settings")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
>  drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c b/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c
> index 6eb9fb9a1814..9c9ae33d84ce 100644
> --- a/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c
> +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c
> @@ -829,8 +829,8 @@ nfp_port_get_fecparam(struct net_device *netdev,
>  	struct nfp_eth_table_port *eth_port;
>  	struct nfp_port *port;
>  
> -	param->active_fec = ETHTOOL_FEC_NONE_BIT;
> -	param->fec = ETHTOOL_FEC_NONE_BIT;
> +	param->active_fec = ETHTOOL_FEC_NONE;
> +	param->fec = ETHTOOL_FEC_NONE;
>  
>  	port = nfp_port_from_netdev(netdev);
>  	eth_port = nfp_port_get_eth_port(port);

Reviewed-by: Simon Horman <simon.horman@...ronome.com>