netdev - Re: [PATCH net] nfp: use correct define to return NONE fec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200917112638.00007d5c@intel.com>
Date:   Thu, 17 Sep 2020 11:26:38 -0700
From:   Jesse Brandeburg <jesse.brandeburg@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        simon.horman@...ronome.com, oss-drivers@...ronome.com
Subject: Re: [PATCH net] nfp: use correct define to return NONE fec

Jakub Kicinski wrote:

> struct ethtool_fecparam carries bitmasks not bit numbers.
> We want to return 1 (NONE), not 0.
> 
> Fixes: 0d0870938337 ("nfp: implement ethtool FEC mode settings")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Good catch!

Reviewed-by: Jesse Brandeburg <jesse.brandeburg@...el.com>