netdev - Re: [BlueZ PATCH v2 1/6] Bluetooth: Update Adv monitor count upon removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 17 Sep 2020 14:15:59 -0700
From:   Luiz Augusto von Dentz <luiz.dentz@...il.com>
To:     Howard Chung <howardchung@...gle.com>
Cc:     "linux-bluetooth@...r.kernel.org" <linux-bluetooth@...r.kernel.org>,
        Marcel Holtmann <marcel@...tmann.org>,
        Manish Mandlik <mmandlik@...omium.org>,
        Miao-chen Chou <mcchou@...omium.org>,
        Alain Michaud <alainm@...omium.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "open list:NETWORKING [GENERAL]" <netdev@...r.kernel.org>
Subject: Re: [BlueZ PATCH v2 1/6] Bluetooth: Update Adv monitor count upon removal

Hi Howard,

On Thu, Sep 17, 2020 at 1:47 AM Howard Chung <howardchung@...gle.com> wrote:
>
> From: Miao-chen Chou <mcchou@...omium.org>
>
> This fixes the count of Adv monitor upon monitor removal.
>
> The following test was performed.
> - Start two btmgmt consoles, issue a btmgmt advmon-remove command on one
> console and observe a MGMT_EV_ADV_MONITOR_REMOVED event on the other.
>
> Signed-off-by: Miao-chen Chou <mcchou@...omium.org>
> Signed-off-by: Howard Chung <howardchung@...gle.com>
> Reviewed-by: Alain Michaud <alainm@...omium.org>
> ---
>
> Changes in v2:
> - delete 'case 0x001c' in mgmt_config.c
>
>  net/bluetooth/hci_core.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
> index 8a2645a833013..f30a1f5950e15 100644
> --- a/net/bluetooth/hci_core.c
> +++ b/net/bluetooth/hci_core.c
> @@ -3061,6 +3061,7 @@ static int free_adv_monitor(int id, void *ptr, void *data)
>
>         idr_remove(&hdev->adv_monitors_idr, monitor->handle);
>         hci_free_adv_monitor(monitor);
> +       hdev->adv_monitors_cnt--;
>
>         return 0;
>  }
> @@ -3077,6 +3078,7 @@ int hci_remove_adv_monitor(struct hci_dev *hdev, u16 handle)
>
>                 idr_remove(&hdev->adv_monitors_idr, monitor->handle);
>                 hci_free_adv_monitor(monitor);
> +               hdev->adv_monitors_cnt--;
>         } else {
>                 /* Remove all monitors if handle is 0. */
>                 idr_for_each(&hdev->adv_monitors_idr, &free_adv_monitor, hdev);
> --
> 2.28.0.618.gf4bc123cb7-goog

This looks like a kernel patch so you shouldn't be prefixing it with
BlueZ as it might confuse CI.

-- 
Luiz Augusto von Dentz