netdev - Re: [PATCH net] drivers/net/wan/lapbether: Make skb->protocol consistent with the header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200917.163824.1681362492378748718.davem@davemloft.net>
Date:   Thu, 17 Sep 2020 16:38:24 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     xie.he.0141@...il.com
Cc:     kuba@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, ms@....tdt.de
Subject: Re: [PATCH net] drivers/net/wan/lapbether: Make skb->protocol
 consistent with the header

From: Xie He <xie.he.0141@...il.com>
Date: Wed, 16 Sep 2020 09:49:18 -0700

> This driver is a virtual driver stacked on top of Ethernet interfaces.
> 
> When this driver transmits data on the Ethernet device, the skb->protocol
> setting is inconsistent with the Ethernet header prepended to the skb.
> 
> This causes a user listening on the Ethernet interface with an AF_PACKET
> socket, to see different sll_protocol values for incoming and outgoing
> frames, because incoming frames would have this value set by parsing the
> Ethernet header.
> 
> This patch changes the skb->protocol value for outgoing Ethernet frames,
> making it consistent with the Ethernet header prepended. This makes a
> user listening on the Ethernet device with an AF_PACKET socket, to see
> the same sll_protocol value for incoming and outgoing frames.
> 
> Cc: Martin Schiller <ms@....tdt.de>
> Signed-off-by: Xie He <xie.he.0141@...il.com>

Applied, thank you.