netdev - Re: [PATCH net-next 1/2] net: mdio: mdio-bcm-unimac: Turn on PHY clock before dummy read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200917.164011.166801140665121114.davem@davemloft.net>
Date:   Thu, 17 Sep 2020 16:40:11 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     f.fainelli@...il.com
Cc:     netdev@...r.kernel.org, andrew@...n.ch, hkallweit1@...il.com,
        kuba@...nel.org
Subject: Re: [PATCH net-next 1/2] net: mdio: mdio-bcm-unimac: Turn on PHY
 clock before dummy read

From: Florian Fainelli <f.fainelli@...il.com>
Date: Wed, 16 Sep 2020 13:44:14 -0700

> @@ -160,6 +160,7 @@ static int unimac_mdio_reset(struct mii_bus *bus)
>  {
>  	struct device_node *np = bus->dev.of_node;
>  	struct device_node *child;
> +	struct clk *clk;
>  	u32 read_mask = 0;
>  	int addr;

Please preserve the reverse christmas tree ordering of these local
variables, thank you.