netdev - Re: [PATCH net-next] liquidio: Fix -Wmissing-prototypes warnings for liquidio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <43ba897632383543e6d7e82f141ad14a265b46f7.camel@kernel.org>
Date:   Fri, 18 Sep 2020 10:43:50 -0700
From:   Saeed Mahameed <saeed@...nel.org>
To:     Wang Hai <wanghai38@...wei.com>, dchickles@...vell.com,
        sburla@...vell.com, fmanlunas@...vell.com, davem@...emloft.net,
        kuba@...nel.org
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] liquidio: Fix -Wmissing-prototypes warnings
 for liquidio

On Fri, 2020-09-18 at 21:02 +0800, Wang Hai wrote:
> If the header file containing a function's prototype isn't included
> by
> the sourcefile containing the associated function, the build system
> complains of missing prototypes.
> 
> Fixes the following W=1 kernel build warning(s):
> 
> drivers/net/ethernet/cavium/liquidio/cn68xx_device.c:124:5: warning:
> no previous prototype for ‘lio_setup_cn68xx_octeon_device’ [-
> Wmissing-prototypes]
> drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:159:1: warning:
> no previous prototype for ‘octeon_pci_read_core_mem’ [-Wmissing-
> prototypes]
> drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:168:1: warning:
> no previous prototype for ‘octeon_pci_write_core_mem’ [-Wmissing-
> prototypes]
> drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:176:5: warning:
> no previous prototype for ‘octeon_read_device_mem64’ [-Wmissing-
> prototypes]
> drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:185:5: warning:
> no previous prototype for ‘octeon_read_device_mem32’ [-Wmissing-
> prototypes]
> drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:194:6: warning:
> no previous prototype for ‘octeon_write_device_mem32’ [-Wmissing-
> prototypes]
> 
> Signed-off-by: Wang Hai <wanghai38@...wei.com>
> 

Reviewed-by: Saeed Mahameed <saeedm@...dia.com>