netdev - RE: [PATCH net-next v2 0/8] devlink: Add SF add/delete devlink ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BY5PR12MB43222DFADC76AE0780BC7C83DC3F0@BY5PR12MB4322.namprd12.prod.outlook.com>
Date:   Fri, 18 Sep 2020 17:47:24 +0000
From:   Parav Pandit <parav@...dia.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH net-next v2 0/8] devlink: Add SF add/delete devlink ops



> From: Jakub Kicinski <kuba@...nel.org>
> Sent: Friday, September 18, 2020 11:07 PM
> 
> On Fri, 18 Sep 2020 17:08:15 +0000 Parav Pandit wrote:
> > > From: Jakub Kicinski <kuba@...nel.org>
> > > Sent: Friday, September 18, 2020 10:22 PM
> > >
> > > On Thu, 17 Sep 2020 20:20:12 +0300 Parav Pandit wrote:
> > > > Hi Dave, Jakub,
> > > >
> > > > Similar to PCI VF, PCI SF represents portion of the device.
> > > > PCI SF is represented using a new devlink port flavour.
> > > >
> > > > This short series implements small part of the RFC described in
> > > > detail at [1]
> > > and [2].
> > > >
> > > > It extends
> > > > (a) devlink core to expose new devlink port flavour 'pcisf'.
> > > > (b) Expose new user interface to add/delete devlink port.
> > > > (c) Extends netdevsim driver to simulate PCI PF and SF ports
> > > > (d) Add port function state attribute
> > >
> > > Is this an RFC? It doesn't add any in-tree users.
> > It is not an RFC.
> > devlink + mlx5 + netdevsim is crossing 25+ patches on eswitch side.
> > So splitting it to logical piece as devlink + netdevsim.
> > After which mlx5 eswitch side come close to 15 + 4 patches which can
> > run as two separate patchset.
> >
> > What do you suggest?
> 
> Start with real patches, not netdevsim.

Hmm. Shall I split the series below, would that be ok?

First patchset,
(a) devlink piece to add/delete port
(b) mlx5 counter part

Second patchset,
(a) devlink piece to set the state
(b) mlx5 counter part

Follow on patchset to create/delete sf's netdev on virtbus in mlx5 + devlink plumbing.
Netdevsim after that.