lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 18 Sep 2020 11:43:48 -0700 From: Saeed Mahameed <saeed@...nel.org> To: Srujana Challa <schalla@...vell.com>, herbert@...dor.apana.org.au, davem@...emloft.net Cc: netdev@...r.kernel.org, linux-crypto@...r.kernel.org, kuba@...nel.org, sgoutham@...vell.com, gakula@...vell.com, sbhatta@...vell.com, schandran@...vell.com, pathreya@...vell.com, Lukas Bartosik <lbartosik@...vell.com> Subject: Re: [PATCH v3,net-next,3/4] drivers: crypto: add support for OCTEONTX2 CPT engine On Thu, 2020-09-17 at 18:58 +0530, Srujana Challa wrote: > Add support for the cryptographic acceleration unit (CPT) on > > OcteonTX2 CN96XX SoC. > > > > Signed-off-by: Suheil Chandran <schandran@...vell.com> > > Signed-off-by: Lukas Bartosik <lbartosik@...vell.com> > > Signed-off-by: Srujana Challa <schalla@...vell.com> > > --- [...] > 15 files changed, 5088 insertions(+) Huge patch, i suggest to break the whole series up to smaller patches, i suggest each component in a separate patch (e.g: infrastructure, new mbox, debugfs, etc..) What linux interfaces are going to enable your ipsec features? i couldn't find any netdev, xfrm references in your series .. and the cover letter + commit messages lack of such information. FYI checkpatch is not happy at all with this patch: total: 0 errors, 2 warnings, 85 checks, 5094 lines checked 85 mostly legit checks fire up.
Powered by blists - more mailing lists