netdev - Re: [PATCH net-next] net: microchip: Remove set but not used variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200919.140939.2137825862652726442.davem@davemloft.net>
Date:   Sat, 19 Sep 2020 14:09:39 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     zhengyongjun3@...wei.com
Cc:     bryan.whitehead@...rochip.com, UNGLinuxDriver@...rochip.com,
        kuba@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: microchip: Remove set but not used
 variable

From: Zheng Yongjun <zhengyongjun3@...wei.com>
Date: Sat, 19 Sep 2020 10:39:09 +0800

> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/net/ethernet/microchip/lan743x_main.c: In function lan743x_pm_suspend:
> drivers/net/ethernet/microchip/lan743x_main.c:3041:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
> 
> `ret` is set but not used, so check it's value.

Subject is still wrong, please fix this and take your time doing
so.

Thanks.