netdev - 答复: [PATCH net-next] net: microchip: Remove set but not used variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 19 Sep 2020 03:08:57 +0000
From:   zhengyongjun <zhengyongjun3@...wei.com>
To:     "bryan.whitehead@...rochip.com" <bryan.whitehead@...rochip.com>,
        "UNGLinuxDriver@...rochip.com" <UNGLinuxDriver@...rochip.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: 答复: [PATCH net-next] net: microchip: Remove set but not used variable

This is the bad patch, my fault, I forget to check patch title, please ignore it, thank you very much.

-----邮件原件-----
发件人: zhengyongjun 
发送时间: 2020年9月19日 10:39
收件人: bryan.whitehead@...rochip.com; UNGLinuxDriver@...rochip.com; davem@...emloft.net; kuba@...nel.org; netdev@...r.kernel.org; linux-kernel@...r.kernel.org
抄送: zhengyongjun <zhengyongjun3@...wei.com>
主题: [PATCH net-next] net: microchip: Remove set but not used variable

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/net/ethernet/microchip/lan743x_main.c: In function lan743x_pm_suspend:
drivers/net/ethernet/microchip/lan743x_main.c:3041:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]

`ret` is set but not used, so check it's value.

Signed-off-by: Zheng Yongjun <zhengyongjun3@...wei.com>
---
 drivers/net/ethernet/microchip/lan743x_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/microchip/lan743x_main.c b/drivers/net/ethernet/microchip/lan743x_main.c
index de93cc6ebc1a..56a1b5928f9a 100644
--- a/drivers/net/ethernet/microchip/lan743x_main.c
+++ b/drivers/net/ethernet/microchip/lan743x_main.c
@@ -3053,7 +3053,7 @@ static int lan743x_pm_suspend(struct device *dev)
 	/* Host sets PME_En, put D3hot */
 	ret = pci_prepare_to_sleep(pdev);
 
-	return 0;
+	return ret;
 }
 
 static int lan743x_pm_resume(struct device *dev)
-- 
2.17.1