netdev - Re: [PATCH net-next] net: remove unnecessary NULL checking in napi_consume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200920.141828.2231994847752545633.davem@davemloft.net>
Date:   Sun, 20 Sep 2020 14:18:28 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     linyunsheng@...wei.com
Cc:     kuba@...nel.org, linmiaohe@...wei.com, martin.varghese@...ia.com,
        fw@...len.de, edumazet@...gle.com, dcaratti@...hat.com,
        steffen.klassert@...unet.com, pabeni@...hat.com,
        kyk.segfault@...il.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linuxarm@...wei.com
Subject: Re: [PATCH net-next] net: remove unnecessary NULL checking in
 napi_consume_skb()

From: Yunsheng Lin <linyunsheng@...wei.com>
Date: Sat, 19 Sep 2020 10:24:47 +0800

> When budget is non-zero, skb_unref() has already handled the
> NULL checking.
> 
> When budget is zero, the dev_consume_skb_any() has handled NULL
> checking in __dev_kfree_skb_irq(), or dev_kfree_skb() which also
> ultimately call skb_unref().
> 
> So remove the unnecessary checking in napi_consume_skb().
> 
> Signed-off-by: Yunsheng Lin <linyunsheng@...wei.com>

Applied.