netdev - Re: [PATCH v2] net: sctp: Fix IPv6 ancestor_size calc in sctp_copy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200920.141629.590298755126729557.davem@davemloft.net>
Date:   Sun, 20 Sep 2020 14:16:29 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     hptasinski@...gle.com
Cc:     marcelo.leitner@...il.com, linux-sctp@...r.kernel.org,
        netdev@...r.kernel.org, vyasevich@...il.com, nhorman@...driver.com,
        kuba@...nel.org, cminyard@...sta.com
Subject: Re: [PATCH v2] net: sctp: Fix IPv6 ancestor_size calc in
 sctp_copy_descendant

From: Henry Ptasinski <hptasinski@...gle.com>
Date: Sat, 19 Sep 2020 00:12:11 +0000

> When calculating ancestor_size with IPv6 enabled, simply using
> sizeof(struct ipv6_pinfo) doesn't account for extra bytes needed for
> alignment in the struct sctp6_sock. On x86, there aren't any extra
> bytes, but on ARM the ipv6_pinfo structure is aligned on an 8-byte
> boundary so there were 4 pad bytes that were omitted from the
> ancestor_size calculation.  This would lead to corruption of the
> pd_lobby pointers, causing an oops when trying to free the sctp
> structure on socket close.
> 
> Fixes: 636d25d557d1 ("sctp: not copy sctp_sock pd_lobby in sctp_copy_descendant")
> Signed-off-by: Henry Ptasinski <hptasinski@...gle.com>

Applied and queued up for -stable, thank you.