netdev - Re: [PATCH net-next 0/2] Devlink regions for SJA1105 DSA driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200921194753.axrpneh3eugz757r@skbuf>
Date:   Mon, 21 Sep 2020 19:47:54 +0000
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     Florian Fainelli <f.fainelli@...il.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "vivien.didelot@...il.com" <vivien.didelot@...il.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "cphealy@...il.com" <cphealy@...il.com>,
        "jiri@...dia.com" <jiri@...dia.com>
Subject: Re: [PATCH net-next 0/2] Devlink regions for SJA1105 DSA driver

On Mon, Sep 21, 2020 at 09:42:10PM +0200, Andrew Lunn wrote:
> On Mon, Sep 21, 2020 at 07:10:09PM +0000, Vladimir Oltean wrote:
> > On Mon, Sep 21, 2020 at 09:03:27PM +0200, Andrew Lunn wrote:
> > > Vladimir, could you implement the devlink DEVLINK_CMD_INFO_GET request
> > > so we know what sort of device is exporting the regions, and hence
> > > which pretty printers are relevant.
> > 
> > Should I do that in this series or separately?
> 
> Up to you. I added it as part of the regions patchset.

I was planning to add that only if I need to resend this series,
otherwise I would go with a follow-on.

> I need to know which particular device it is in order to decode the
> registers correctly.

For sja1105, the device id is part of the static config, so the region
is self explanatory in that regard. But if we create a larger tool then
it makes sense to report the device in DEVLINK_CMD_INFO_GET.

Thanks,
-Vladimir