lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Tue, 22 Sep 2020 17:37:13 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     vladimir.oltean@....com
Cc:     netdev@...r.kernel.org, andrew@...n.ch, vivien.didelot@...il.com,
        f.fainelli@...il.com, kuba@...nel.org, cphealy@...il.com,
        jiri@...dia.com
Subject: Re: [PATCH net-next 2/2] net: dsa: sja1105: expose static config
 as devlink region

From: Vladimir Oltean <vladimir.oltean@....com>
Date: Mon, 21 Sep 2020 19:27:41 +0300

> @@ -110,10 +222,15 @@ int sja1105_devlink_setup(struct dsa_switch *ds)
>  	if (rc)
>  		return rc;
>  
> +	rc = sja1105_setup_devlink_regions(ds);
> +	if (rc < 0)
> +		return rc;
> +
>  	return 0;
>  }

I think you need to release the devlink params on failure here.  Otherwise
I don't see anything that will clean that up.

Powered by blists - more mailing lists