netdev - Re: [PATCH bpf-next v5] bpf: Add bpf_ktime_get_real

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5a4c7ac0-254b-bd25-8eeb-1bef86cd374f@iogearbox.net>
Date:   Fri, 25 Sep 2020 00:27:03 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     David Ahern <dsahern@...il.com>, bimmy.pujari@...el.com,
        bpf@...r.kernel.org
Cc:     netdev@...r.kernel.org, mchehab@...nel.org, ast@...nel.org,
        kafai@...com, maze@...gle.com, ashkan.nikravesh@...el.com
Subject: Re: [PATCH bpf-next v5] bpf: Add bpf_ktime_get_real_ns

On 9/25/20 12:15 AM, David Ahern wrote:
> On 9/24/20 4:07 PM, bimmy.pujari@...el.com wrote:
>> diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h
>> index a22812561064..198e69a6508d 100644
>> --- a/include/uapi/linux/bpf.h
>> +++ b/include/uapi/linux/bpf.h
>> @@ -3586,6 +3586,13 @@ union bpf_attr {
>>    * 		the data in *dst*. This is a wrapper of **copy_from_user**\ ().
>>    * 	Return
>>    * 		0 on success, or a negative error in case of failure.
>> + *
>> + * u64 bpf_ktime_get_real_ns(void)
>> + *	Description
>> + *		Return the real time in nanoseconds.
>> + *		See: **clock_gettime**\ (**CLOCK_REALTIME**)
> 
> This should be a little more explicit -- something like "See the caveats
> regarding use of CLOCK_REALTIME in clock_gettime man page."

+1, and also other feedback got ignored along the way [0]; please don't just resend
several new revisions in the meantime when there were things that still need to be
addressed. Thanks!

   [0] https://lore.kernel.org/bpf/d232b77c-da79-da1c-e564-e2a5cb64acb6@iogearbox.net/T/#ma2997c90e80329c457eb92e9592e185f27ce222f