netdev - Re: [PATCH v2] net: lantiq: Add locking for TX DMA channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFBinCBQ1mx-Pg6kzZoHLp4i_Te5_i5NZWMTF_VqF90LGRWOfA@mail.gmail.com>
Date:   Fri, 25 Sep 2020 14:19:08 +0200
From:   Martin Blumenstingl <martin.blumenstingl@...glemail.com>
To:     David Miller <davem@...emloft.net>
Cc:     Hauke Mehrtens <hauke@...ke-m.de>, kuba@...nel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH v2] net: lantiq: Add locking for TX DMA channel

On Thu, Sep 24, 2020 at 3:01 AM David Miller <davem@...emloft.net> wrote:
>
> From: Hauke Mehrtens <hauke@...ke-m.de>
> Date: Tue, 22 Sep 2020 23:41:12 +0200
>
> > The TX DMA channel data is accessed by the xrx200_start_xmit() and the
> > xrx200_tx_housekeeping() function from different threads. Make sure the
> > accesses are synchronized by acquiring the netif_tx_lock() in the
> > xrx200_tx_housekeeping() function too. This lock is acquired by the
> > kernel before calling xrx200_start_xmit().
> >
> > Signed-off-by: Hauke Mehrtens <hauke@...ke-m.de>
Tested-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>

> Applied, but...
>
> You posted this really fast after my feedback, so I have to ask if you
> actually functionally tested this patch?
it fixes the following crash for me: [0]


Best regards,
Martin


[0] https://pastebin.com/t1SLz9PH