netdev - Re: [PATCH v2] net: lantiq: Add locking for TX DMA channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1fbe5104-68bb-64b7-22c4-fcdd51ebe6a1@hauke-m.de>
Date:   Sat, 26 Sep 2020 21:30:23 +0200
From:   Hauke Mehrtens <hauke@...ke-m.de>
To:     David Miller <davem@...emloft.net>
Cc:     kuba@...nel.org, netdev@...r.kernel.org,
        martin.blumenstingl@...glemail.com
Subject: Re: [PATCH v2] net: lantiq: Add locking for TX DMA channel

On 9/24/20 3:01 AM, David Miller wrote:
> From: Hauke Mehrtens <hauke@...ke-m.de>
> Date: Tue, 22 Sep 2020 23:41:12 +0200
> 
>> The TX DMA channel data is accessed by the xrx200_start_xmit() and the
>> xrx200_tx_housekeeping() function from different threads. Make sure the
>> accesses are synchronized by acquiring the netif_tx_lock() in the
>> xrx200_tx_housekeeping() function too. This lock is acquired by the
>> kernel before calling xrx200_start_xmit().
>>
>> Signed-off-by: Hauke Mehrtens <hauke@...ke-m.de>
> 
> Applied, but...
> 
> You posted this really fast after my feedback, so I have to ask if you
> actually functionally tested this patch?
> 

Hi David,

I created the patch first, then tested it with ipef3 (iperf3 -c
192.168.1.70 -P 10 -t 30 and reverse) multiple times and send both mails.

I did not see any problems, but it could still be that I miss more problems.

Hauke



Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)