netdev - Re: Request for Comment: LED device naming for netdev LEDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 27 Sep 2020 03:13:06 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Marek Behun <marek.behun@....cz>
Cc:     netdev <netdev@...r.kernel.org>, linux-leds@...r.kernel.org,
        David Miller <davem@...emloft.net>,
        Russell King <linux@...linux.org.uk>
Subject: Re: Request for Comment: LED device naming for netdev LEDs

> So I will have
>   /sys/class/net/eth0/phydev/leds/eth0:green:activity
>                  |        |
>                  symlink  |
>                           |
>                         symlink
> 
> and I will also have
>   /sys/class/leds/eth0:green:activity
>                   |
>                   symlink

So this forces the name to be globally unique, not netns unique. So
you cannot use the interface name alone.

i don't think the name is actually too important. You are going to
find it via /sys/class/net/eth0/phydev/leds/eth0:green:activity so the
proposal of an incremental number works.

    Andrew