netdev - Re: [PATCH ethtool 2/2] netlink: fix memory leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200928153705.etztslrdglekpadj@lion.mk-sys.cz>
Date:   Mon, 28 Sep 2020 17:37:05 +0200
From:   Michal Kubecek <mkubecek@...e.cz>
To:     Ivan Vecera <ivecera@...hat.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH ethtool 2/2] netlink: fix memory leak

On Thu, Sep 24, 2020 at 09:27:58PM +0200, Ivan Vecera wrote:
> Potentially allocated memory allocated for mask is not freed when
> the allocation for value fails.
> 
> Fixes: 81a30f416ec7 ("netlink: add bitset command line parser handlers")
> 
> Cc: Michal Kubecek <mkubecek@...e.cz>
> Signed-off-by: Ivan Vecera <ivecera@...hat.com>
> ---

Applied, thank you.

Michal

>  netlink/parser.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/netlink/parser.c b/netlink/parser.c
> index c5a368a65a7a..3b25f5d5a88e 100644
> --- a/netlink/parser.c
> +++ b/netlink/parser.c
> @@ -630,8 +630,10 @@ static int parse_numeric_bitset(struct nl_context *nlctx, uint16_t type,
>  	}
>  
>  	value = calloc(nwords, sizeof(uint32_t));
> -	if (!value)
> +	if (!value) {
> +		free(mask);
>  		return -ENOMEM;
> +	}
>  	ret = __parse_num_string(arg, len1, value, force_hex1);
>  	if (ret < 0) {
>  		parser_err_invalid_value(nlctx, arg);
> -- 
> 2.26.2
> 

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)