netdev - Re: [PATCH ethtool 1/2] fix memory leaks in do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200928153740.a7kr6m3r2hrl77qk@lion.mk-sys.cz>
Date:   Mon, 28 Sep 2020 17:37:40 +0200
From:   Michal Kubecek <mkubecek@...e.cz>
To:     Ivan Vecera <ivecera@...hat.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH ethtool 1/2] fix memory leaks in do_sfeatures()

On Fri, Sep 25, 2020 at 09:05:26AM +0200, Ivan Vecera wrote:
> Memory blocks referenced by new_state and old_state are never freed.
> For efeatures there is no need to check pointer as free() can be called
> with NULL parameter.
> 
> Fixes: 6042804cf6ec ("Change -k/-K options to use ETHTOOL_{G,S}FEATURES")
> 
> Cc: Michal Kubecek <mkubecek@...e.cz>
> Signed-off-by: Ivan Vecera <ivecera@...hat.com>
> ---

Applied, thank you.

Michal

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)