netdev - Re: [PATCH net] drivers/net/wan/x25_asy: Keep the ldisc running even when netif is down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200928.155852.490566722532403628.davem@davemloft.net>
Date:   Mon, 28 Sep 2020 15:58:52 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     xie.he.0141@...il.com
Cc:     kuba@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, ms@....tdt.de
Subject: Re: [PATCH net] drivers/net/wan/x25_asy: Keep the ldisc running
 even when netif is down

From: Xie He <xie.he.0141@...il.com>
Date: Sat, 26 Sep 2020 13:56:10 -0700

> @@ -265,7 +269,9 @@ static void x25_asy_write_wakeup(struct tty_struct *tty)
>  		 * transmission of another packet */
>  		sl->dev->stats.tx_packets++;
>  		clear_bit(TTY_DO_WRITE_WAKEUP, &tty->flags);
> -		x25_asy_unlock(sl);
> +		/* FIXME: The netif may go down after netif_running returns */
> +		if (netif_running(sl->dev))
> +			x25_asy_unlock(sl);
>  		return;

It could also go back down and also back up again after you do this
test.  Maybe even 10 or 100 times over.

You can't just leave things so incredibly racy like this, please apply
proper synchronization between netdev state changes and this TTY code.

Thank you.