netdev - Re: [PATCH net] drivers/net/wan/x25_asy: Keep the ldisc running even when netif is down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJht_EPs03cTh=6PQWasZknRXOzysW-X+dC+RPMu02RsC417LA@mail.gmail.com>
Date:   Mon, 28 Sep 2020 17:36:13 -0700
From:   Xie He <xie.he.0141@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Martin Schiller <ms@....tdt.de>
Subject: Re: [PATCH net] drivers/net/wan/x25_asy: Keep the ldisc running even
 when netif is down

On Mon, Sep 28, 2020 at 3:58 PM David Miller <davem@...emloft.net> wrote:
>
> It could also go back down and also back up again after you do this
> test.  Maybe even 10 or 100 times over.
>
> You can't just leave things so incredibly racy like this, please apply
> proper synchronization between netdev state changes and this TTY code.
>
> Thank you.

OK! Thanks!

I'll try to ensure proper locking for the netif_running checks and re-submit.