netdev - Re: [PATCH net-next] ip6gre: avoid tx_error when sending MLD/DAD on external tunnels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200928.160154.653590366401035900.davem@davemloft.net>
Date:   Mon, 28 Sep 2020 16:01:54 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dcaratti@...hat.com
Cc:     jishi@...hat.com, kuba@...nel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] ip6gre: avoid tx_error when sending MLD/DAD
 on external tunnels

From: Davide Caratti <dcaratti@...hat.com>
Date: Sun, 27 Sep 2020 16:08:21 +0200

> similarly to what has been done with commit 9d149045b3c0 ("geneve: change
> from tx_error to tx_dropped on missing metadata"), avoid reporting errors
> to userspace in case the kernel doesn't find any tunnel information for a
> skb that is going to be transmitted: an increase of tx_dropped is enough.
> 
> tested with the following script:
> 
>  # for t in ip6gre ip6gretap ip6erspan; do
>  > ip link add dev gre6-test0 type $t external
>  > ip address add dev gre6-test0 2001:db8::1/64
>  > ip link set dev gre6-test0 up
>  > sleep 30
>  > ip -s -j link show dev gre6-test0 | jq \
>  > '.[0].stats64.tx | {"errors": .errors, "dropped": .dropped}'
>  > ip link del dev gre6-test0
>  > done
> 
> Reported-by: Jianlin Shi <jishi@...hat.com>
> Signed-off-by: Davide Caratti <dcaratti@...hat.com>

Applied.