lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 28 Sep 2020 08:50:11 +0200 From: Greg Kroah-Hartman <gregkh@...uxfoundation.org> To: Thomas Gleixner <tglx@...utronix.de> Cc: LKML <linux-kernel@...r.kernel.org>, Peter Zijlstra <peterz@...radead.org>, Linus Torvalds <torvalds@...uxfoundation.org>, Paul McKenney <paulmck@...nel.org>, Matthew Wilcox <willy@...radead.org>, Sebastian Andrzej Siewior <bigeasy@...utronix.de>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, linux-usb@...r.kernel.org, netdev@...r.kernel.org, Christian Benvenuti <benve@...co.com>, Govindarajulu Varadarajan <_govind@....com>, Jonathan Corbet <corbet@....net>, Mauro Carvalho Chehab <mchehab+huawei@...nel.org>, linux-doc@...r.kernel.org, Luc Van Oostenryck <luc.vanoostenryck@...il.com>, Jay Cliburn <jcliburn@...il.com>, Chris Snook <chris.snook@...il.com>, Vishal Kulkarni <vishal@...lsio.com>, Jeff Kirsher <jeffrey.t.kirsher@...el.com>, intel-wired-lan@...ts.osuosl.org, Shannon Nelson <snelson@...sando.io>, Pensando Drivers <drivers@...sando.io>, Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>, Thomas Bogendoerfer <tsbogend@...ha.franken.de>, Solarflare linux maintainers <linux-net-drivers@...arflare.com>, Edward Cree <ecree@...arflare.com>, Martin Habets <mhabets@...arflare.com>, Jon Mason <jdmason@...zu.us>, Daniel Drake <dsd@...too.org>, Ulrich Kunitz <kune@...ne-taler.de>, Kalle Valo <kvalo@...eaurora.org>, linux-wireless@...r.kernel.org, Arend van Spriel <arend.vanspriel@...adcom.com>, Franky Lin <franky.lin@...adcom.com>, Hante Meuleman <hante.meuleman@...adcom.com>, Chi-Hsien Lin <chi-hsien.lin@...ress.com>, Wright Feng <wright.feng@...ress.com>, brcm80211-dev-list.pdl@...adcom.com, brcm80211-dev-list@...ress.com, Stanislav Yakovlev <stas.yakovlev@...il.com>, Stanislaw Gruszka <stf_xl@...pl>, Johannes Berg <johannes.berg@...el.com>, Emmanuel Grumbach <emmanuel.grumbach@...el.com>, Luca Coelho <luciano.coelho@...el.com>, Intel Linux Wireless <linuxwifi@...el.com>, Jouni Malinen <j@...fi>, Amitkumar Karwar <amitkarwar@...il.com>, Ganapathi Bhat <ganapathi.bhat@....com>, Xinming Hu <huxinming820@...il.com>, libertas-dev@...ts.infradead.org, Pascal Terjan <pterjan@...gle.com>, Ping-Ke Shih <pkshih@...ltek.com> Subject: Re: [patch 21/35] net: usb: kaweth: Remove last user of kaweth_control() On Sun, Sep 27, 2020 at 09:49:07PM +0200, Thomas Gleixner wrote: > From: Sebastian Andrzej Siewior <bigeasy@...utronix.de> > > kaweth_async_set_rx_mode() invokes kaweth_contol() and has two callers: > > - kaweth_open() which is invoked from preemptible context > . > - kaweth_start_xmit() which holds a spinlock and has bottom halfs disabled. > > If called from kaweth_start_xmit() kaweth_async_set_rx_mode() obviously > cannot block, which means it can't call kaweth_control(). This is detected > with an in_interrupt() check. > > Replace the in_interrupt() check in kaweth_async_set_rx_mode() with an > argument which is set true by the caller if the context is safe to sleep, > otherwise false. > > Now kaweth_control() is only called from preemptible context which means > there is no need for GFP_ATOMIC allocations anymore. Replace it with > usb_control_msg(). Cleanup the code a bit while at it. > > Finally remove kaweth_control() since the last user is gone. > > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de> > Signed-off-by: Thomas Gleixner <tglx@...utronix.de> > Cc: "David S. Miller" <davem@...emloft.net> > Cc: Jakub Kicinski <kuba@...nel.org> > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org> > Cc: linux-usb@...r.kernel.org > Cc: netdev@...r.kernel.org Thanks for the cleanup, that driver really needed it! Reviewed-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Powered by blists - more mailing lists