lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 28 Sep 2020 11:34:22 +0200
From:   Arend Van Spriel <>
To:     Thomas Gleixner <>,
        LKML <>
Cc:     Peter Zijlstra <>,
        Linus Torvalds <>,
        Paul McKenney <>,
        Matthew Wilcox <>,
        Sebastian Andrzej Siewior <>,
        Franky Lin <>,
        Hante Meuleman <>,
        Chi-Hsien Lin <>,
        Wright Feng <>,
        Kalle Valo <>,
        "David S. Miller" <>,
        Jakub Kicinski <>,,,,,
        Christian Benvenuti <>,
        Govindarajulu Varadarajan <>,
        Jonathan Corbet <>,
        Mauro Carvalho Chehab <>,,
        Luc Van Oostenryck <>,
        Jay Cliburn <>,
        Chris Snook <>,
        Vishal Kulkarni <>,
        Jeff Kirsher <>,,
        Shannon Nelson <>,
        Pensando Drivers <>,
        Andrew Lunn <>,
        Heiner Kallweit <>,
        Russell King <>,
        Thomas Bogendoerfer <>,
        Solarflare linux maintainers <>,
        Edward Cree <>,
        Martin Habets <>,
        Jon Mason <>, Daniel Drake <>,
        Ulrich Kunitz <>,,
        Greg Kroah-Hartman <>,
        Stanislav Yakovlev <>,
        Stanislaw Gruszka <>,
        Johannes Berg <>,
        Emmanuel Grumbach <>,
        Luca Coelho <>,
        Intel Linux Wireless <>,
        Jouni Malinen <>,
        Amitkumar Karwar <>,
        Ganapathi Bhat <>,
        Xinming Hu <>,,
        Pascal Terjan <>,
        Ping-Ke Shih <>
Subject: Re: [patch 26/35] net: brcmfmac: Convey allocation mode as argument

On 9/27/2020 9:49 PM, Thomas Gleixner wrote:
> From: Sebastian Andrzej Siewior <>
> The usage of in_interrupt() in drivers is phased out and Linus clearly
> requested that code which changes behaviour depending on context should
> either be seperated or the context be conveyed in an argument passed by the
> caller, which usually knows the context.
> brcmf_fweh_process_event() uses in_interrupt() to select the allocation
> mode GFP_KERNEL/GFP_ATOMIC. Aside of the above reasons this check is
> incomplete as it cannot detect contexts which just have preemption or
> interrupts disabled.
> All callchains leading to brcmf_fweh_process_event() can clearly identify
> the calling context. Convey a 'gfp' argument through the callchains and let
> the callers hand in the appropriate GFP mode.
> This has also the advantage that any change of execution context or
> preemption/interrupt state in these callchains will be detected by the
> memory allocator for all GFP_KERNEL allocations.

Looking at the functions changed I see overlap with patch 25/35 so maybe 
change to gfp flag to a 'in_isr' bool. The flag can then be used for 
dealing with netif_rx as well.


Download attachment "smime.p7s" of type "application/pkcs7-signature" (4176 bytes)

Powered by blists - more mailing lists