netdev - Re: [PATCH 2/2] net: qrtr: Allow non-immediate node routing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200929144144.GE71055@builder.lan>
Date:   Tue, 29 Sep 2020 09:41:44 -0500
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Loic Poulain <loic.poulain@...aro.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, clew@...eaurora.org,
        manivannan.sadhasivam@...aro.org
Subject: Re: [PATCH 2/2] net: qrtr: Allow non-immediate node routing

On Tue 29 Sep 08:33 CDT 2020, Loic Poulain wrote:

> In order to reach non-immediate remote node services that are
> accessed through an intermediate node, the route to the remote
> node needs to be saved.
> 
> E.g for a [node1 <=> node2 <=> node3] network
> - node2 forwards node3 service to node1
> - node1 must save node2 as route for reaching node3
> 
> Signed-off-by: Loic Poulain <loic.poulain@...aro.org>

Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>

Regards,
Bjorn

> ---
>  net/qrtr/qrtr.c | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c
> index e09154b..bd9bcea 100644
> --- a/net/qrtr/qrtr.c
> +++ b/net/qrtr/qrtr.c
> @@ -400,12 +400,13 @@ static void qrtr_node_assign(struct qrtr_node *node, unsigned int nid)
>  {
>  	unsigned long flags;
>  
> -	if (node->nid != QRTR_EP_NID_AUTO || nid == QRTR_EP_NID_AUTO)
> +	if (nid == QRTR_EP_NID_AUTO)
>  		return;
>  
>  	spin_lock_irqsave(&qrtr_nodes_lock, flags);
>  	radix_tree_insert(&qrtr_nodes, nid, node);
> -	node->nid = nid;
> +	if (node->nid == QRTR_EP_NID_AUTO)
> +		node->nid = nid;
>  	spin_unlock_irqrestore(&qrtr_nodes_lock, flags);
>  }
>  
> @@ -493,6 +494,12 @@ int qrtr_endpoint_post(struct qrtr_endpoint *ep, const void *data, size_t len)
>  
>  	qrtr_node_assign(node, cb->src_node);
>  
> +	if (cb->type == QRTR_TYPE_NEW_SERVER) {
> +		/* Remote node endpoint can bridge other distant nodes */
> +		const struct qrtr_ctrl_pkt *pkt = data + hdrlen;
> +		qrtr_node_assign(node, le32_to_cpu(pkt->server.node));
> +	}
> +
>  	if (cb->type == QRTR_TYPE_RESUME_TX) {
>  		qrtr_tx_resume(node, skb);
>  	} else {
> -- 
> 2.7.4
>