netdev - Re: [PATCH 2/2] net: qrtr: Allow non-immediate node routing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200929085559.0ee3564c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 29 Sep 2020 08:55:59 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Loic Poulain <loic.poulain@...aro.org>
Cc:     bjorn.andersson@...aro.org, davem@...emloft.net,
        netdev@...r.kernel.org, clew@...eaurora.org,
        manivannan.sadhasivam@...aro.org
Subject: Re: [PATCH 2/2] net: qrtr: Allow non-immediate node routing

On Tue, 29 Sep 2020 15:33:17 +0200 Loic Poulain wrote:
> +	if (cb->type == QRTR_TYPE_NEW_SERVER) {
> +		/* Remote node endpoint can bridge other distant nodes */
> +		const struct qrtr_ctrl_pkt *pkt = data + hdrlen;
> +		qrtr_node_assign(node, le32_to_cpu(pkt->server.node));

checkpatch says:

WARNING: Missing a blank line after declarations
#47: FILE: net/qrtr/qrtr.c:501:
+		const struct qrtr_ctrl_pkt *pkt = data + hdrlen;
+		qrtr_node_assign(node, le32_to_cpu(pkt->server.node));