netdev - Re: [PATCH net-next 1/1] l2tp: report rx cookie discards in netlink get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200929121625.GA4556@katalix.com>
Date:   Tue, 29 Sep 2020 13:16:25 +0100
From:   Tom Parkin <tparkin@...alix.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, jchapman@...alix.com
Subject: Re: [PATCH net-next 1/1] l2tp: report rx cookie discards in netlink
 get

On  Mon, Sep 28, 2020 at 18:46:25 -0700, David Miller wrote:
> From: Tom Parkin <tparkin@...alix.com>
> Date: Mon, 28 Sep 2020 13:46:34 +0100
> 
> > --- a/include/uapi/linux/l2tp.h
> > +++ b/include/uapi/linux/l2tp.h
> > @@ -143,6 +143,7 @@ enum {
> >  	L2TP_ATTR_RX_SEQ_DISCARDS,	/* u64 */
> >  	L2TP_ATTR_RX_OOS_PACKETS,	/* u64 */
> >  	L2TP_ATTR_RX_ERRORS,		/* u64 */
> > +	L2TP_ATTR_RX_COOKIE_DISCARDS,	/* u64 */
> >  	L2TP_ATTR_STATS_PAD,
> >  	__L2TP_ATTR_STATS_MAX,
> >  };
> 
> You can't change the value of the L2TP_ATTR_STATS_PAD attribute.
> 
> Instead you must add new values strictly right before the
> __L2TP_ATTR_STATS_MAX.

Of course, my mistake :-(

I'll respin accordingly, thanks.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)