netdev - Re: [PATCH net-next 1/1] l2tp: report rx cookie discards in netlink get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 28 Sep 2020 18:46:25 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     tparkin@...alix.com
Cc:     netdev@...r.kernel.org, jchapman@...alix.com
Subject: Re: [PATCH net-next 1/1] l2tp: report rx cookie discards in
 netlink get

From: Tom Parkin <tparkin@...alix.com>
Date: Mon, 28 Sep 2020 13:46:34 +0100

> --- a/include/uapi/linux/l2tp.h
> +++ b/include/uapi/linux/l2tp.h
> @@ -143,6 +143,7 @@ enum {
>  	L2TP_ATTR_RX_SEQ_DISCARDS,	/* u64 */
>  	L2TP_ATTR_RX_OOS_PACKETS,	/* u64 */
>  	L2TP_ATTR_RX_ERRORS,		/* u64 */
> +	L2TP_ATTR_RX_COOKIE_DISCARDS,	/* u64 */
>  	L2TP_ATTR_STATS_PAD,
>  	__L2TP_ATTR_STATS_MAX,
>  };

You can't change the value of the L2TP_ATTR_STATS_PAD attribute.

Instead you must add new values strictly right before the
__L2TP_ATTR_STATS_MAX.