netdev - Re: [PATCH net-next 0/3] net: atlantic: phy tunables from mac driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200929103320.6a5de6f1@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 29 Sep 2020 10:33:20 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Igor Russkikh <irusskikh@...vell.com>, netdev@...r.kernel.org,
        "David S . Miller" <davem@...emloft.net>
Subject: Re: [PATCH net-next 0/3] net: atlantic: phy tunables from mac
 driver

On Tue, 29 Sep 2020 19:04:13 +0200 Andrew Lunn wrote:
> On Tue, Sep 29, 2020 at 07:13:04PM +0300, Igor Russkikh wrote:
> > This series implements phy tunables settings via MAC driver callbacks.
> > 
> > AQC 10G devices use integrated MAC+PHY solution, where PHY is fully controlled
> > by MAC firmware. Therefore, it is not possible to implement separate phy driver
> > for these.
> > 
> > We use ethtool ops callbacks to implement downshift and EDPC tunables.  
> 
> Hi Michal
> 
> Do you have any code to implement tunables via netlink?
> 
> This code is defining new ethtool calls. It seems like now would be a
> good time to plumb in extack, so the driver can report back the valid
> range of a tunable when given an unsupported value.

Do you mean report supported range via extack? Perhaps we should have 
a real API for that kind of info? We can plumb it through to the core
for now and expose to user space once netlink comes.