netdev - Re: ethtool/phy tunables and extack (was Re: [PATCH net-next 0/3] net: atlantic: phy tunables from mac driver)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200930153132.pi3zsomcz63rcsvl@lion.mk-sys.cz>
Date:   Wed, 30 Sep 2020 17:31:32 +0200
From:   Michal Kubecek <mkubecek@...e.cz>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Igor Russkikh <irusskikh@...vell.com>, netdev@...r.kernel.org,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: ethtool/phy tunables and extack (was Re: [PATCH net-next 0/3]
 net: atlantic: phy tunables from mac driver)

On Wed, Sep 30, 2020 at 05:16:56PM +0200, Andrew Lunn wrote:
> > Another question is how to allow ethtool ops setting not only the text
> > message but also the offending attribute.
> 
> For PHY tunables, i don't think it is needed. The current API only
> allows a single value to be passed. That seems to be enough, and it
> forces us to keep tunables simple. If need be, the core could set the
> attribute, since there should only be one containing the value.

It probably wasn't obvious but I mean the two parts of my e-mail as
independent, i.e. the second part was rather meant as a general thought
on allowing drivers to report errors/warnings via extack, not specific
to PHY tunables.

Michal