netdev - Re: [EXT] Re: [PATCH net-next 3/3] net: atlantic: implement media detect feature via phy tunables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <04e72671-aa3e-ac11-ef92-bb17fc633a60@marvell.com>
Date:   Thu, 1 Oct 2020 13:18:06 +0300
From:   Igor Russkikh <irusskikh@...vell.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     <netdev@...r.kernel.org>, "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [EXT] Re: [PATCH net-next 3/3] net: atlantic: implement media
 detect feature via phy tunables

Hi Andrew,

> Since this is your own PHY, not some magical black box, i assume you
> actually know what value it is using? It probably even lists it in the
> data sheet.
> 
> So just hard code that value in the driver. That has got to be better
> than saying the incorrect value of 1ms.

You mean always return that value in get_, and ignore what we get in set_ ?
That could be done, will investigate.

Thanks for the review,
  Igor