lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 30 Sep 2020 08:22:58 +0200 From: Greg Kroah-Hartman <gregkh@...uxfoundation.org> To: Thomas Gleixner <tglx@...utronix.de> Cc: LKML <linux-kernel@...r.kernel.org>, Peter Zijlstra <peterz@...radead.org>, Paul McKenney <paulmck@...nel.org>, Matthew Wilcox <willy@...radead.org>, Christian Benvenuti <benve@...co.com>, Govindarajulu Varadarajan <_govind@....com>, Dave Miller <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org, Jonathan Corbet <corbet@....net>, Mauro Carvalho Chehab <mchehab+huawei@...nel.org>, linux-doc@...r.kernel.org, Sebastian Andrzej Siewior <bigeasy@...utronix.de>, Luc Van Oostenryck <luc.vanoostenryck@...il.com>, Jay Cliburn <jcliburn@...il.com>, Chris Snook <chris.snook@...il.com>, Vishal Kulkarni <vishal@...lsio.com>, Jeff Kirsher <jeffrey.t.kirsher@...el.com>, intel-wired-lan@...ts.osuosl.org, Shannon Nelson <snelson@...sando.io>, Pensando Drivers <drivers@...sando.io>, Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>, Thomas Bogendoerfer <tsbogend@...ha.franken.de>, Solarflare linux maintainers <linux-net-drivers@...arflare.com>, Edward Cree <ecree@...arflare.com>, Martin Habets <mhabets@...arflare.com>, Jon Mason <jdmason@...zu.us>, Daniel Drake <dsd@...too.org>, Ulrich Kunitz <kune@...ne-taler.de>, Kalle Valo <kvalo@...eaurora.org>, linux-wireless@...r.kernel.org, linux-usb@...r.kernel.org, Arend van Spriel <arend.vanspriel@...adcom.com>, Franky Lin <franky.lin@...adcom.com>, Hante Meuleman <hante.meuleman@...adcom.com>, Chi-Hsien Lin <chi-hsien.lin@...ress.com>, Wright Feng <wright.feng@...ress.com>, brcm80211-dev-list.pdl@...adcom.com, brcm80211-dev-list@...ress.com, Stanislav Yakovlev <stas.yakovlev@...il.com>, Stanislaw Gruszka <stf_xl@...pl>, Johannes Berg <johannes.berg@...el.com>, Emmanuel Grumbach <emmanuel.grumbach@...el.com>, Luca Coelho <luciano.coelho@...el.com>, Intel Linux Wireless <linuxwifi@...el.com>, Jouni Malinen <j@...fi>, Amitkumar Karwar <amitkarwar@...il.com>, Ganapathi Bhat <ganapathi.bhat@....com>, Xinming Hu <huxinming820@...il.com>, libertas-dev@...ts.infradead.org, Pascal Terjan <pterjan@...gle.com>, Ping-Ke Shih <pkshih@...ltek.com> Subject: Re: [patch V2 21/36] net: usb: kaweth: Replace kaweth_control() with usb_control_msg() On Tue, Sep 29, 2020 at 10:25:30PM +0200, Thomas Gleixner wrote: > From: Sebastian Andrzej Siewior <bigeasy@...utronix.de> > > kaweth_control() is almost the same as usb_control_msg() except for the > memory allocation mode (GFP_ATOMIC vs GFP_NOIO) and the in_interrupt() > check. > > All the invocations of kaweth_control() are within the probe function in > fully preemtible context so there is no reason to use atomic allocations, > GFP_NOIO which is used by usb_control_msg() is perfectly fine. > > Replace kaweth_control() invocations from probe with usb_control_msg(). > > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de> > Signed-off-by: Thomas Gleixner <tglx@...utronix.de> Note, the usb_control_msg_send/recv() new functions that will show up in 5.10-rc1 will help a bit with this logic, but for what you have now, this is fine, nice cleanups. Reviewed-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Powered by blists - more mailing lists