netdev - Re: [PATCH bpf-next v6 1/2] bpf: Add bpf_ktime_get_real

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 1 Oct 2020 08:56:08 +0800
From:   kernel test robot <lkp@...el.com>
To:     bimmy.pujari@...el.com, bpf@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, netdev@...r.kernel.org,
        mchehab@...nel.org, ast@...nel.org, daniel@...earbox.net,
        kafai@...com, maze@...gle.com, bimmy.pujari@...el.com,
        ashkan.nikravesh@...el.com, Daniel.A.Alvarez@...el.com
Subject: Re: [PATCH bpf-next v6 1/2] bpf: Add bpf_ktime_get_real_ns

Hi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on bpf-next/master]

url:    https://github.com/0day-ci/linux/commits/bimmy-pujari-intel-com/bpf-Add-bpf_ktime_get_real_ns/20201001-063024
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/5b19ed9ce24c3c15a4da400e9c3b18aa31d6eb36
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review bimmy-pujari-intel-com/bpf-Add-bpf_ktime_get_real_ns/20201001-063024
        git checkout 5b19ed9ce24c3c15a4da400e9c3b18aa31d6eb36
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=xtensa 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/media/rc/bpf-lirc.c: In function 'lirc_mode2_func_proto':
>> drivers/media/rc/bpf-lirc.c:109:38: error: expected ';' before 'case'
     109 |   return &bpf_ktime_get_real_ns_proto
         |                                      ^
         |                                      ;
     110 |  case BPF_FUNC_tail_call:
         |  ~~~~                                 

vim +109 drivers/media/rc/bpf-lirc.c

    81	
    82	static const struct bpf_func_proto *
    83	lirc_mode2_func_proto(enum bpf_func_id func_id, const struct bpf_prog *prog)
    84	{
    85		switch (func_id) {
    86		case BPF_FUNC_rc_repeat:
    87			return &rc_repeat_proto;
    88		case BPF_FUNC_rc_keydown:
    89			return &rc_keydown_proto;
    90		case BPF_FUNC_rc_pointer_rel:
    91			return &rc_pointer_rel_proto;
    92		case BPF_FUNC_map_lookup_elem:
    93			return &bpf_map_lookup_elem_proto;
    94		case BPF_FUNC_map_update_elem:
    95			return &bpf_map_update_elem_proto;
    96		case BPF_FUNC_map_delete_elem:
    97			return &bpf_map_delete_elem_proto;
    98		case BPF_FUNC_map_push_elem:
    99			return &bpf_map_push_elem_proto;
   100		case BPF_FUNC_map_pop_elem:
   101			return &bpf_map_pop_elem_proto;
   102		case BPF_FUNC_map_peek_elem:
   103			return &bpf_map_peek_elem_proto;
   104		case BPF_FUNC_ktime_get_ns:
   105			return &bpf_ktime_get_ns_proto;
   106		case BPF_FUNC_ktime_get_boot_ns:
   107			return &bpf_ktime_get_boot_ns_proto;
   108		case BPF_FUNC_ktime_get_real_ns:
 > 109			return &bpf_ktime_get_real_ns_proto
   110		case BPF_FUNC_tail_call:
   111			return &bpf_tail_call_proto;
   112		case BPF_FUNC_get_prandom_u32:
   113			return &bpf_get_prandom_u32_proto;
   114		case BPF_FUNC_trace_printk:
   115			if (perfmon_capable())
   116				return bpf_get_trace_printk_proto();
   117			fallthrough;
   118		default:
   119			return NULL;
   120		}
   121	}
   122	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (65151 bytes)