netdev - Re: [PATCH net-next v2 4/4] dpaa2-eth: add support for devlink parser error drop traps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 1 Oct 2020 13:19:18 +0000
From:   Ioana Ciornei <ioana.ciornei@....com>
To:     Ido Schimmel <idosch@...sch.org>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "jiri@...dia.com" <jiri@...dia.com>,
        "idosch@...dia.com" <idosch@...dia.com>
Subject: Re: [PATCH net-next v2 4/4] dpaa2-eth: add support for devlink parser
 error drop traps

On Wed, Sep 30, 2020 at 10:44:07PM +0300, Ido Schimmel wrote:
> On Wed, Sep 30, 2020 at 10:16:45PM +0300, Ioana Ciornei wrote:
> > +static int dpaa2_eth_dl_trap_action_set(struct devlink *devlink,
> > +					const struct devlink_trap *trap,
> > +					enum devlink_trap_action action,
> > +					struct netlink_ext_ack *extack)
> > +{
> > +	/* No support for changing the action of an independent packet trap,
> > +	 * only per trap group - parser error drops
> > +	 */
> > +	return -EOPNOTSUPP;
> 
> Please also add an error message via extack
> 
Sure.