netdev - Re: [PATCH net-next v2 4/4] dpaa2-eth: add support for devlink parser error drop traps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200930172537.0e41772a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 30 Sep 2020 17:25:37 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Ioana Ciornei <ioana.ciornei@....com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, jiri@...dia.com,
        idosch@...dia.com
Subject: Re: [PATCH net-next v2 4/4] dpaa2-eth: add support for devlink
 parser error drop traps

On Wed, 30 Sep 2020 22:16:45 +0300 Ioana Ciornei wrote:
> Add support for the new group of devlink traps - PARSER_ERROR_DROPS.
> This consists of registering the array of parser error drops supported,
> controlling their action through the .trap_group_action_set() callback
> and reporting an erroneous skb received on the error queue
> appropriately.
> DPAA2 devices do not support controlling the action of independent
> parser error traps, thus the .trap_action_set() callback just returns an
> EOPNOTSUPP while .trap_group_action_set() actually notifies the hardware
> what it should do with a frame marked as having a header error.
> 
> Signed-off-by: Ioana Ciornei <ioana.ciornei@....com>

On a 32bit build:

drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c: In function ‘setup_rx_err_flow’:
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c:3422:19: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
 3422 |  q.user_context = (u64)fq;
      |                   ^
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c:3422:31: warning: non size-preserving pointer to integer cast