netdev - Re: [net 01/15] net/mlx5: Don't allow health work when device is uninitialized

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20201001.122120.1497340751468134272.davem@davemloft.net>
Date:   Thu, 01 Oct 2020 12:21:20 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     saeed@...nel.org
Cc:     kuba@...nel.org, netdev@...r.kernel.org, shayd@...lanox.com,
        saeedm@...lanox.com, saeedm@...dia.com
Subject: Re: [net 01/15] net/mlx5: Don't allow health work when device is
 uninitialized

From: saeed@...nel.org
Date: Wed, 30 Sep 2020 19:05:02 -0700

> @@ -201,6 +206,9 @@ void mlx5_enter_error_state(struct mlx5_core_dev *dev, bool force)
>  		err_detected = true;
>  	}
>  	mutex_lock(&dev->intf_state_mutex);
> +	if (!mlx5_is_device_initialized(dev))
> +		return;
> +

You can return with this mutex held, and that's ok?

I think you have to "goto unlock;" or similar.