netdev - Re: [net 01/15] net/mlx5: Don't allow health work when device is uninitialized

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <119a39b1c6bae3ef90e61e741399380022000459.camel@kernel.org>
Date:   Thu, 01 Oct 2020 12:41:13 -0700
From:   Saeed Mahameed <saeed@...nel.org>
To:     David Miller <davem@...emloft.net>
Cc:     kuba@...nel.org, netdev@...r.kernel.org, shayd@...lanox.com,
        saeedm@...lanox.com
Subject: Re: [net 01/15] net/mlx5: Don't allow health work when device is
 uninitialized

On Thu, 2020-10-01 at 12:21 -0700, David Miller wrote:
> From: saeed@...nel.org
> Date: Wed, 30 Sep 2020 19:05:02 -0700
> 
> > @@ -201,6 +206,9 @@ void mlx5_enter_error_state(struct
> mlx5_core_dev *dev, bool force)
> >               err_detected = true;
> >       }
> >       mutex_lock(&dev->intf_state_mutex);
> > +     if (!mlx5_is_device_initialized(dev))
> > +             return;
> > +
> 
> You can return with this mutex held, and that's ok?
> 
> I think you have to "goto unlock;" or similar.

goto unlock is needed,
thanks for spotting this, I will fix and send v2.