netdev - Re: [PATCH net] r8169: fix data corruption issue on RTL8402

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20201001.123825.1055916571334326788.davem@davemloft.net>
Date:   Thu, 01 Oct 2020 12:38:25 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     kuba@...nel.org, nic_swsd@...ltek.com, netdev@...r.kernel.org,
        ptesarik@...e.cz
Subject: Re: [PATCH net] r8169: fix data corruption issue on RTL8402

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Thu, 1 Oct 2020 09:23:02 +0200

> Petr reported that after resume from suspend RTL8402 partially
> truncates incoming packets, and re-initializing register RxConfig
> before the actual chip re-initialization sequence is needed to avoid
> the issue.
> 
> Reported-by: Petr Tesarik <ptesarik@...e.cz>
> Proposed-by: Petr Tesarik <ptesarik@...e.cz>
> Tested-by: Petr Tesarik <ptesarik@...e.cz>
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> ---
> Hard to provide a Fixes tag because it seems the issue has been
> always there. Due to frequent changes in function rtl8169_resume()
> we would need a number of different fixes for the stable kernel
> versions. That the issue was reported only now indicates that chip
> version RTL8402 is rare. Therefore treat this change mainly as an
> improvement. This fix version applies from 5.9 after just submitted
> fix "r8169: fix handling ether_clk".

Applied and queued up for -stable.

In the future you can use a Fixes: tag using the root commit of the
entire Linux git tree in situations like this.

Thanks.